On Wed, Jun 16, 2010 at 3:18 PM, Juan Quintela <quint...@redhat.com> wrote: > Corentin Chary <corenti...@iksaif.net> wrote: >> Add gradient filter and JPEG compression with an heuristic to detect how >> lossy the comppression will be. This code has been adapted from >> libvncserver/tight.c. >> >> JPEG support can be enabled/disabled at compile time with --enable-vnc-jpeg >> and --disable-vnc-jpeg. >> >> Signed-off-by: Corentin Chary <corenti...@iksaif.net> >> --- >> Makefile.target | 1 + >> configure | 33 +++ >> vnc-encoding-tight.c | 559 >> +++++++++++++++++++++++++++++++++++++++++++++++++- >> vnc-encoding-tight.h | 5 + >> vnc.h | 4 + >> 5 files changed, 601 insertions(+), 1 deletions(-) >> >> diff --git a/Makefile.target b/Makefile.target >> index 478b89d..d9e888a 100644 >> --- a/Makefile.target >> +++ b/Makefile.target >> @@ -177,6 +177,7 @@ LIBS+=-lz >> >> QEMU_CFLAGS += $(VNC_TLS_CFLAGS) >> QEMU_CFLAGS += $(VNC_SASL_CFLAGS) >> +QEMU_CFLAGS += $(VNC_JPEG_CFLAGS) >> >> # xen backend driver support >> obj-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o >> diff --git a/configure b/configure >> index c0d8aa5..304b4b0 100755 >> --- a/configure >> +++ b/configure >> @@ -268,6 +268,7 @@ uuid="" >> vde="" >> vnc_tls="" >> vnc_sasl="" >> +vnc_jpeg="" > > init it to "no" > >> xen="" >> linux_aio="" >> vhost_net="" > >> ########################################## >> +# VNC JPEG detection >> +if test "$vnc_jpeg" = "yes" ; then > > and use here != "no" as a test as the rest of the conditions, that way > you only need to look in one place to know what is the default. >
I guess the same thing apply to PNG and Threaded server. Would it be ok to send a cumulative patch to fix that ? Thanks, -- Corentin Chary http://xf.iksaif.net
