On 03/22/2016 09:33 AM, Kevin Wolf wrote: > It was already true in principle that a throttled BDS always has a BB > attached, except that the order of operations while attaching or > detaching a BDS to/from a BB wasn't careful enough. > > This commit breaks graph manipulations while I/O throttling is enabled. > It would have been possible, but quite cumbersome, to keep things > working with some temporary hacks, so it's not worth the hassle. We'll > fix things again in a minute.
Might read slightly better as: It would have been possible to keep things working with some temporary hacks, but quite cumbersome, so it's not worth the hassle. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > +#if 0 > bdrv_io_limits_enable(bs_new, throttle_group_get_name(bs_top)); > bdrv_io_limits_disable(bs_top); > +#else > + abort(); If it weren't fixed in the same series, then I'd want some text to go along with the abort. But since it's temporary, this is fine. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
