On Tue, 22 Mar 2016 08:24:33 +0800 Fam Zheng <f...@redhat.com> wrote:
> On Thu, 03/17 11:01, Cornelia Huck wrote: > > diff --git a/include/hw/virtio/virtio-bus.h b/include/hw/virtio/virtio-bus.h > > index 3f2c136..0281cbf 100644 > > --- a/include/hw/virtio/virtio-bus.h > > +++ b/include/hw/virtio/virtio-bus.h > > @@ -71,6 +71,16 @@ typedef struct VirtioBusClass { > > void (*device_unplugged)(DeviceState *d); > > int (*query_nvectors)(DeviceState *d); > > /* > > + * ioeventfd handling: if the transport implements ioeventfd_started, > > + * it must implement the other ioeventfd callbacks as well > > + */ > > + bool (*ioeventfd_started)(DeviceState *d); > > + void (*ioeventfd_set_started)(DeviceState *d, bool started, bool err); > > + bool (*ioeventfd_disabled)(DeviceState *d); > > + void (*ioeventfd_set_disabled)(DeviceState *d, bool disabled); > > + int (*ioeventfd_assign)(DeviceState *d, EventNotifier *notifier, > > + int n, bool assign); > > Maybe we should consider documenting these operations and parameters? Yes, we should :) I just wanted to make sure first that this is the way to go.