You're welcome Jason. Dear Denis,
The policy with e1000 was to keep it as much as possible to the real Hardware, That's why I think we should keep it 500 even though 250 pushes the performance to the limit. Jason what do you think about that? On Fri, Mar 18, 2016 at 3:34 AM, Jason Wang <jasow...@redhat.com> wrote: > > > On 03/17/2016 03:37 PM, Sameeh Jubran wrote: > > This patch series introduces an upper bound for the number of interrupts > > per second. This feature is supported by the real hardware, however up > > until now it wasn't implemented in e1000. This feature is very > > significant, it can prevent an interrupt storm by giving the driver > > a bounded inter-interrupt interval to handle interrupts. > > > > This patch was made after observing an interrupt storm in Windows 10 > > when disabling e1000. > > > > How reproducible: > > > > Steps to reproduce: > > 1. Start Win 10 guest with e1000 device. > > 2. Go to device manager and try to disable and enable the device. > > 3. After several enable/disable to the device the guest hangs when > > the device is being disabled. > > > > Actual results: > > Guest hang after click OK button. > > > > Expected results: > > Device is disabled. > > > > After applying the patch the guest no longer hangs, and an Iperf test > > ran successfully. > > > > Sameeh Jubran (2): > > e1000: Fixing interrupts pace. > > Revert "e1000: fix hang of win2k12 shutdown with flood ping" > > > > hw/net/e1000.c | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > > Applied. > > Thanks Sameeh > -- Respectfully, *Sameeh Jubran* *Mobile: +972 054-2509642* *Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>Junior Software Engineer @ Daynix <http://www.daynix.com>.*
