On 03/17/2016 03:50 PM, Li Zhijian wrote:
>>
>> +static void filter_redirector_fini(Object *obj)
>> +{
>> +    MirrorState *s = FILTER_REDIRECTOR(obj);
>> +
>> +    qemu_chr_add_handlers(s->chr_in, NULL, NULL, NULL, NULL);
>
> hi, Jason
> Do we reset the chardev handler here is reasonable ?
> filter_redirector_fini() is destruction of filter_redirector_init()
> which we
> don't register handler.
>
> So, I think move the handler reset to filter_redirector_cleanup()
> would be better.
>
> Thanks
> Li 

Yes, please.

Thanks

Reply via email to