On Di, 2016-03-15 at 15:17 +0100, Christophe Fergeau wrote: > On Tue, Mar 15, 2016 at 02:09:47PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > Yes, long-term we will want to remove this once spice gets support for > > > this. > > > > How can qemu figure whenever spice supports gl+tcp or not? > > gl support is already enabled through a spice-server version check > > #if defined(CONFIG_OPENGL_DMABUF) > # if SPICE_SERVER_VERSION >= 0x000d01 /* release 0.13.1 */ > # define HAVE_SPICE_GL 1 > # include "ui/egl-helpers.h" > # include "ui/egl-context.h" > # endif > #endif
Sure, qemu needed to figure whenever spice-server provides the gl API. > We can do something similar once gl+tcp is available. I don't expect adding gl+tcp support to spice needs changes in the spice-server API and qemu. So ifdef'ing on the spice-server version is bogous, especially as the version you compiled qemu against can be newer or older as the version used to run qemu. cheers, Gerd
