Richard Henderson <r...@twiddle.net> writes:
> On 03/04/2016 03:18 AM, Alex Bennée wrote:
>> + case '+':
>> + {
>> + unsigned long len;
>> + err |= qemu_strtoull(r2, NULL, 0, &len);
>> + if (len > 0) {
>> + range.end = range.begin + (len - 1);
>> + } else {
>> + err |= true;
>> + }
>> + break;
>> + }
>> + case '-':
>> + {
>> + unsigned long len;
>> + err |= qemu_strtoull(r2, NULL, 0, &len);
>> + range.end = range.begin;
>> + range.begin = range.end - len;
>> + break;
>> + }
>
> Doesn't '-' have the same off-by-one bug?
Doh. of course, I'll get that fixed.
> Although really I don't understand the need for negative ranges...
It's a shortcut, something went wrong at X, lets dump the code from X-n
to X to catch the run up to it.
>
>
> r~
--
Alex Bennée
