On 03/14/2016 04:43 PM, Thomas Huth wrote: > On 14.03.2016 15:53, Cédric Le Goater wrote: >> Hello Thomas, >> >> On 03/11/2016 03:46 PM, Thomas Huth wrote: >>> I'd maybe also squash the "Add KVM numbers to some P8 SPRs" patch into >>> the "Add a bunch of hypervisor SPRs to Book3s" to reduce the code churn >>> a little bit (note that the patch description for the "Add a bunch of >>> hypervisor SPRs to Book3s" patch is misleading - DAWR and DAWRX need to >>> be synchronized for migration, since the guest can set this register via >>> the H_SET_MODE hypercall). >> >> So shall I just remove the comment : >> >> "We don't give them a KVM reg number yet as no current KVM version >> supports HV mode." >> >> from patch "Add a bunch of hypervisor SPRs to Book3s" after squashing in >> "Add KVM numbers to some P8 SPRs" ? > > Either that, or change it into something like: > > "We don't give them a KVM reg number to most of the registers yet as no > current KVM version supports HV mode. For DAWR and DAWRX, the KVM reg > number is needed since this register can be set by the guest via the > H_SET_MODE hypercall."
OK. Good. I should be sending a first patchset soon the list, after a few checks. Thanks, C.