On 03/12/2016 01:36 PM, rutu.shah...@gmail.com wrote: > From: Rutuja Shah <rutu.shah...@gmail.com> > > This patch adds NULL check for return value from qemu_find_file(), where it > is missing. It avoids unnecessary function calls with NULL parameter which in > turn return -1. Especially, incase of load_uimage(), two functions are called > which return -1 on passing NULL
Please wrap your commit messages at 70 or so columns (since 'git log' will display your text with indentation, and many people still prefer 80-column terminal windows). s/incase/in case/ > --- > hw/ppc/e500.c | 17 +++++++++++++---- > hw/sparc/leon3.c | 6 +++++- > 2 files changed, 18 insertions(+), 5 deletions(-) > > > Signed-off-by: Rutuja Shah <rutu.shah...@gmail.com> This S-o-b is in the wrong place; it needs to appear before the --- separator to be included in the git log after a maintainer does 'git am' on your patch. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
