On 03/08/2016 12:51 PM, Peter Maydell wrote: > On 7 March 2016 at 10:12, Jason Wang <jasow...@redhat.com> wrote: >> The following changes since commit 1464ad45cd6cdeb0b5c1a54d3d3791396e47e52f: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-04' >> into staging (2016-03-06 11:53:27 +0000) >> >> are available in the git repository at: >> >> https://github.com/jasowang/qemu.git tags/net-pull-request >> >> for you to fetch changes up to a2f2e45c6edbba9e1961056fa77c696208b40c8e: >> >> net: check packet payload length (2016-03-07 10:15:48 +0800) >> >> ---------------------------------------------------------------- >> >> - a new netfilter implementation: mirror >> - netfilter could be disabled and enabled through qom-set now >> - fix netfilter crash when specifiying wrong parameters >> - rocker switch now can allow user to specifiy world >> - fix OOB access for ne2000 > Hi; I'm afraid this makes "make check" hang for me (Linux, x86-64): > > TEST: tests/test-netfilter... (pid=26854) > /i386/netfilter/addremove_one: OK > /i386/netfilter/remove_netdev_one: OK > /i386/netfilter/addremove_multi: OK > /i386/netfilter/remove_netdev_multi: OK > PASS: tests/test-netfilter > TEST: tests/test-filter-mirror... (pid=26858) > /i386/netfilter/mirror: > > (consistently, every time I run make check, on the same test). > > thanks > -- PMM
Sorry, it manages to pass on my machine before submitting the pull request. But when I re-try this several times, it fails. This probably means we have bug in mirror implementation. Chen and Congyang, please try to fix this bug and resubmit a new version of the patch. Will drop mirror from this pull request and submit a V2. Thanks
