On 03/07/2016 04:41 AM, Samuel Thibault wrote: > Jason Wang, on Mon 07 Mar 2016 15:05:05 +0800, wrote: >> Please do unnecessary changes like this since it will cause extra effort >> for git blame and other things. > > Ok. I just do hope that no other reviewer will come and say that we > should fix the alignment of the parameters.
Alignment doesn't matter; in fact, most qapi .json files use 'name': 'type with a single space after : for every parameter, rather than trying to align things. It doesn't bother me either way (or I would have pointed it out sooner), but reindenting is more churn than I would personally do. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
