On Wed, Mar 02, 2016 at 11:09:29AM -0500, Jeff Cody wrote: > The function qemu_strtoul() reads 'unsigned long' sized data, > which is larger than uint32_t on 64-bit machines. > > Even though the snap_id field in the header is 32-bits, we must > accomodate the full size in qemu_strtoul(). > > This patch also adds more meaningful error handling to the > qemu_strtoul() call, and subsequent results. > > Reported-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Jeff Cody <jc...@redhat.com> > --- > block/sheepdog.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) >
Ideally, one of the other Sheepdog maintainers (Hitoshi Mitake or Liu Yuan) could run a test against this patch, as I don't have an easy way of testing it. Thanks, Jeff
