On 2 March 2016 at 01:09, Andrew Jeffery <and...@aj.id.au> wrote: > Hi Peter, > > On Thu, 2016-02-25 at 16:29 +0000, Peter Maydell wrote: >> On 16 February 2016 at 11:34, Andrew Jeffery <and...@aj.id.au> wrote: >> > +#define AVIC_L_MASK 0xFFFFFFFF >> >> This needs a 'U' suffix or at least one of the compilers we build >> with will complain. > > Okay. Out of interest, what compiler will complain?
Ancient gcc 4.2. (Actually I've now dropped that from the testing set, but I still tend to recommend U suffixes in review.) thanks -- PMM