On Tue, Mar 01, 2016 at 01:03:56PM +0100, Paolo Bonzini wrote: > > > On 01/03/2016 12:58, Daniel P. Berrange wrote: > > > > means that QEMU will never close stderr anymore, so libvirt things > > > > QEMU is still starting up....forever. > > > > > > > > Given current libvirt behaviour / expectations, I think the only > > > > option is to revert this change. > > > > > > Why not fix it instead? :) > > > > Because if the user upgrades QEMU it'll cause all existing deployed > > version of libvirt to hang. I think that's pretty undesirable > > behaviour. > > Let me rephrase, why not fix it in QEMU? Jan Tomko helped me debugging > it, and I've sent a patch just before seeing your message.
Oh, we were talking with crossed wires. Yes, fixing the problem rather than fully reverting the patch is of course a reasonable solution. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
