On Thu 25 Feb 2016 06:33:08 AM CET, Changlong Xie <xiecl.f...@cn.fujitsu.com>
wrote:
> +Read/Write operation:
> { "event": "QUORUM_REPORT_BAD",
> - "data": { "node-name": "node0", "sector-num": 345435, "sectors-count":
> 5 },
> + "data": { "node-name": "node0", "sector-num": 345435, "sectors-count":
> 5,
> + "type": "read" },
> "timestamp": { "seconds": 1344522075, "microseconds": 745528 } }
Since you introduced the 'type' field and this is now an example of a
read error, you can change the description to say simply "Read
operation:". In my opinion there's no need to add yet another example
for a write operation, I think it's clear enough.
> +Flush operation:
> +{ "event": "QUORUM_REPORT_BAD",
> + "data": { "node-name": "node0", "sector-num": 0, "sectors-count":
> 2097120,
> + "type": "flush", "error": "Broken pipe" },
> + "timestamp": { "seconds": 1456406829, "microseconds": 291763 } }
Here (and in the previous case) please indent "type" so it goes under
"node-name":
{ "event": "QUORUM_REPORT_BAD",
"data": { "node-name": "node0", "sector-num": 0, "sectors-count": 2097120,
"type": "flush", "error": "Broken pipe" },
"timestamp": { "seconds": 1456406829, "microseconds": 291763 } }
Otherwise I think the patch looks perfect now. Thanks!
Berto
