On 02/22/2016 10:33 PM, Alberto Garcia wrote:
On Mon 22 Feb 2016 10:50:37 AM CET, Changlong Xie wrote:
- winner = quorum_get_vote_winner(&error_votes);
- result = winner->value.l;
-
+ if (success_count >= s->threshold)
+ result = 0;
+ else {
+ winner = quorum_get_vote_winner(&error_votes);
+ result = winner->value.l;
+ }
Please use braces in both branches of the if. scripts/checkpatch.pl
should report that.
Surely.
Other than that I think the patch is correct, but I still wonder if we
should emit QUORUM_REPORT_BAD (or a new event) for the operations that
To me QUORUM_REPORT_BAD is not a good choice.
fail. Or why wouldn't the user want to be notified of a flush failure?
I'll introduce a new event in next series.
Thanks
-Xie
Berto
.
