On Mon, Feb 22, 2016 at 11:14:44AM -0800, Richard Henderson wrote: > On 02/22/2016 02:19 AM, Paolo Bonzini wrote: > > The xsave and xrstor helpers are accessing the x86_ext_save_areas array > > using a bit mask instead of a bit position. Provide two sets of XSTATE_* > > definitions and use XSTATE_*_BIT when a bit position is requested. > > Whoops. This patch is fine, > > Reviewed-by: Richard Henderson <r...@twiddle.net> > > Dosen't Eduardo have a pending patch set to make xsave use a struct? That > would fix this as well, by not requiring fpu_helper.c to use the > x86_ext_save_areas array at all...
That's true, but the bug fix have priority, so I will queue it first. -- Eduardo