On Wed, Feb 17, 2016 at 1:41 PM, Eric Blake <ebl...@redhat.com> wrote:
> On 02/17/2016 02:04 PM, Alistair Francis wrote:
>> Add a generic loader to QEMU which can be used to load images or set
>> memory values.
>>
>> This only supports ARM architectures at the moment.
>>
>> Signed-off-by: Alistair Francis <alistair.fran...@xilinx.com>
>> ---
>> Changes since RFC:
>> - Add BE support
>>
>
>> hw/misc/generic-loader.c | 127
>> +++++++++++++++++++++++++++++++++++++++
>> include/hw/misc/generic-loader.h | 50 +++++++++++++++
>> 4 files changed, 180 insertions(+)
>> create mode 100644 hw/misc/generic-loader.c
>> create mode 100644 include/hw/misc/generic-loader.h
>
> We really ought to improve checkpatch.pl to flag patches that add new
> files not covered by MAINTAINERS.
Adding an entry for this.
>
>> +++ b/hw/misc/generic-loader.c
>> @@ -0,0 +1,127 @@
>> +/*
>> + * Generic Loader
>> + *
>> + * Copyright (C) 2014 Li Guang
>> + * Written by Li Guang <lig.f...@cn.fujitsu.com>
>
> Want to claim 2016?
Yep, I can do that. I'm never too sure when this can be changed or
not. Should I add a written by as well?
>
>>
>> +
>> +#include "hw/sysbus.h"
>> +#include "sysemu/dma.h"
>> +#include "hw/loader.h"
>> +#include "hw/misc/generic-loader.h"
>
> New .c files should include "qemu/osdep.h" first, before anything else.
Adding it
>
>> +static void generic_loader_realize(DeviceState *dev, Error **errp)
>> +{
>> + GenericLoaderState *s = GENERIC_LOADER(dev);
>> + hwaddr entry;
>> + int big_endian;
>> + int size = 0;
>> +
>> + if (s->cpu_nr != CPU_NONE) {
>> + CPUState *cs = first_cpu;
>> + int cpu_num = 0;
>> +
>> + CPU_FOREACH(cs) {
>> + if (cpu_num == s->cpu_nr) {
>> + s->cpu = cs;
>> + break;
>> + } else if (!CPU_NEXT(cs)) {
>> + error_setg(errp, "Specified boot CPU#%d is non existant",
>> + s->cpu_nr);
>
> s/non existant/nonexistent/
Thanks, fixed
Thanks,
Alistair
>
>
>> +++ b/include/hw/misc/generic-loader.h
>> @@ -0,0 +1,50 @@
>> +/*
>> + * Generic Loader
>> + *
>> + * Copyright (C) 2014 Li Guang
>> + * Written by Li Guang <lig.f...@cn.fujitsu.com>
>
> 2016
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
