On Mon, 02/15 17:59, Alex Bennée wrote: > > Fam Zheng <f...@redhat.com> writes: > > > v1: Since RFC, addressed comments from reviewers, and improved a lot of > > things. > > Thanks to Daniel, Eric, Paolo, Stefan, for the feedback. > > > > This series adds a new "docker" make target family to run tests in created > > docker containers. > > > > To begin with, this can be a place to store standard env/command > > combinations to > > build and test QEMU. > > I think I'm done for this review pass. Please CC me on your next > version.
Sure! > > I've run a quick test on my ARM64 Debian Jessie box which predictably > failed. It looks like this is a docker hub issue for one thing as: > > docker pull debian:stable > > creates an x86_64 image on the arm64 box which predictably fails. I > suspect the only solution is going to be storing our own built images on > the docker hub and tweaking the tooling to take host architecture into > account. Yes I think that makes sense. > > Do you have any non-x86 boxes to test against or are you going to need > some help with non-x86 support? You're right docker isn't platform aware. At the moment I don't have a non-x86 box to test, it is great if you can help. Thanks! Fam