On 15 February 2016 at 14:34, Alex Bennée <alex.ben...@linaro.org> wrote:
>
> Fam Zheng <f...@redhat.com> writes:
>> +cd $(mktemp -d)
>> +mkdir build
>> +mkdir install
>> +cd build
>> +build_qemu --target-list=x86_64-softmmu --prefix="${pwd}/install"Why restrict the target list ? >> +make check $MAKEFLAGS >> +make install > > From my excursions last week into the tests directory I discovered the > unit tests are built for a number of different qtest binaries. For > completeness we should probably include the whole list: > > #+name: qtest-targets > #+begin_src sh :dir ~/lsrc/qemu/qemu.git :results scalar > grep -E "check-qtest-[[:alnum:]]+-y " tests/Makefile | cut -d " " -f 1 | sort > -u > #+end_src > > #+RESULTS: qtest-targets > #+begin_example > check-qtest-arm-y > check-qtest-generic-y > check-qtest-i386-y > check-qtest-ipack-y > check-qtest-microblazeel-y > check-qtest-mips64el-y > check-qtest-mips64-y > check-qtest-mips-y > check-qtest-pci-y > check-qtest-ppc64-y > check-qtest-ppc-y > check-qtest-sh4eb-y > check-qtest-sh4-y > #check-qtest-sparc64-y > check-qtest-sparc64-y > #check-qtest-sparc-y > check-qtest-virtioserial-y > check-qtest-virtio-y > check-qtest-x86_64-y > check-qtest-xtensaeb-y > check-qtest-y > #+end_example I'm having difficulty figuring out what you're proposing here, but it looks like you're suggesting listing all the check-qtest-* test names again here, which seems worth avoiding. We should just do a build and make check and let that take care of running all the tests. thanks -- PMM
