On 02/10/2016 02:20 AM, Samuel Thibault wrote: > Thomas Huth, on Wed 10 Feb 2016 09:42:04 +0100, wrote: >> On 08.02.2016 11:28, Samuel Thibault wrote: >>> Signed-off-by: Guillaume Subiron <maet...@subiron.org> >>> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> >>> --- >>> slirp/tcp_input.c | 99 >>> +++++++++++++++++++++++++++--------------------------- >>> slirp/tcp_output.c | 29 ++++++++-------- >>> slirp/tcp_subr.c | 50 +++++++++++++-------------- >>> 3 files changed, 89 insertions(+), 89 deletions(-) >> >> Not sure, it's just an idea, but maybe it would even make sense to >> re-indent the whole files in the QEMU coding style now? I mean, indent >> with 4 spaces instead of tabs? > > I'm fine with doing it. Maintainers, what do you think?
If done as part of the series, it's probably okay to do it as a pre-requisite patch. Don't mix it in with actual code changes, and we don't do whole-sale reindenting except as part of a larger series (because 'git blame' will point to whoever did the reindenting instead of the original code, which doesn't make sense when reindenting is done in isolation). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
