"Michael S. Tsirkin" <m...@redhat.com> writes: > On Mon, Jun 07, 2010 at 05:42:55PM +0100, Paul Brook wrote: >> > On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: >> > > > With -netdev, there now seems to be little need to support vlans, >> > > > enabling them leads to user confusion and bad performance. >> > > > Disable support for vlans by default, add config option to enable. >> > > >> > > No. If you want to remove vlans, then actually do that. >> > >> > How is this not what this patch does? You mean kill the code >> > completely, not just --contigure option? >> >> Yes. Configure options are bad. If code isn't worth enabling by default then >> you've got to have a very good reason why it exists at all. >> >> Paul > > Everyone ok with disabling vlans with no config option?
Wrong question. You got to ask "anyone *not* ok with disabling vlans with no config option?"