On 6 February 2016 at 18:42, Sergey Fedorov <serge.f...@gmail.com> wrote: > On 03.02.2016 16:38, Peter Maydell wrote: >> --- a/target-arm/helper.c >> +++ b/target-arm/helper.c >> @@ -364,6 +364,23 @@ static CPAccessResult >> access_el3_aa32ns_aa64any(CPUARMState *env, >> return CP_ACCESS_OK; >> } >> >> +/* Some secure-only AArch32 registers trap to EL3 if used from >> + * Secure EL1 (but are just ordinary UNDEF in other non-EL3 contexts). >> + * We assume that the .access field is set to PL1_RW. >> + */ > > Maybe we should also make a note that there is no secure EL1 if EL3 is > using AArch32 as it is done for ats_access()?
I added a line to the comment: * Note that an access from Secure EL1 can only happen if EL3 is AArch64. thanks -- PMM
