Markus Armbruster writes: > Lluís Vilanova <vilan...@ac.upc.edu> writes: >> Markus Armbruster writes: >> >>> This overlaps with parts of Lluís's "[RFC][PATCH v6 0/5] utils: >>> Improve and document error reporting". Lluís, feel free to integrate >>> my patches into a respin of your series. You can also respin on top >>> of my series. >> >> Reviewed-by: Lluís Vilanova <vilan...@ac.upc.edu> >> >> I'm happy with this series as a replacement for mine. Two nitpicks: >> >> * The error.h comments point to assert() instead of abort() as a replacement >> for >> error_setg(&error_abort) (while your HACKING says otherwise).
> Where? Documentation on error_setg() (last phrase) vs HACKING (also last phrase). >> * HACKING does not explicitly point out that exit(1) is the preferred exit >> code. > Does it need saying? We don't seem to have a weird exit() problem in > new code. > The lower HACKING's signal-to-noise ratio gets, the fewer people will > actually read it attentively. Fine by me. Cheers, Lluis
