On 03/02/2016 18:55, Peter Maydell wrote: > On 3 February 2016 at 15:47, Stefan Hajnoczi <stefa...@redhat.com> wrote: >> The following changes since commit c65db7705b7926f4a084b93778e4bd5dd3990aad: >> >> Merge remote-tracking branch >> 'remotes/maxreitz/tags/pull-block-for-peter-2016-02-02' into staging >> (2016-02-02 18:04:04 +0000) >> >> are available in the git repository at: >> >> git://github.com/stefanha/qemu.git tags/tracing-pull-request >> >> for you to fetch changes up to c84ea00dc29b2084a62bd31f498ed0f245d3848e: >> >> log: add "-d trace:PATTERN" (2016-02-03 10:37:50 +0000) >> >> ---------------------------------------------------------------- > > Hi. I'm afraid this fails to compile on Windows: > > In file included from /home/petmay01/linaro/qemu-for-merges/include/trace.h:4, > from > /home/petmay01/linaro/qemu-for-merges/util/oslib-win32.c:38: > ./trace/generated-tracers.h: In function ‘trace_virtio_console_flush_buf’: > ./trace/generated-tracers.h:240: warning: format ‘%zd’ expects type > ‘signed size_t’, but argument 8 has type ‘ssize_t’ > CC util/hbitmap.o > ./trace/generated-tracers.h: In function ‘trace_usb_ohci_iso_td_so’: > ./trace/generated-tracers.h:2784: warning: format ‘%zu’ expects type > ‘size_t’, but argument 11 has type ‘ssize_t’ > ./trace/generated-tracers.h: In function ‘trace_usb_ohci_iso_td_data_overrun’: > ./trace/generated-tracers.h:2796: warning: format ‘%zu’ expects type > ‘size_t’, but argument 7 has type ‘ssize_t’ > CC util/fifo8.o > CC util/acl.o > ./trace/generated-tracers.h: In function ‘trace_spice_vmc_write’: > ./trace/generated-tracers.h:6516: warning: format ‘%zd’ expects type > ‘signed size_t’, but argument 6 has type ‘ssize_t’ > CC util/error.o > CC util/qemu-error.o > cc1: warnings being treated as errors > In file included from /home/petmay01/linaro/qemu-for-merges/include/trace.h:4, > from /home/petmay01/linaro/qemu-for-merges/util/hbitmap.c:18: > ./trace/generated-tracers.h: In function ‘trace_virtio_console_flush_buf’: > ./trace/generated-tracers.h:240: warning: format ‘%zd’ expects type > ‘signed size_t’, but argument 8 has type ‘ssize_t’ > CC util/id.o > CC util/iov.o > ./trace/generated-tracers.h: In function > ‘trace_usb_ohci_iso_td_so’:./trace/generated-tracers.h: In function > ‘trace_v9fs_read_return’: > ./trace/generated-tracers.h:2784: warning: format ‘%zu’ expects type > ‘size_t’, but argument 11 has type ‘ssize_t’ > ./trace/generated-tracers.h: In function ‘trace_usb_ohci_iso_td_data_overrun’: > ./trace/generated-tracers.h:2796: warning: format ‘%zu’ expects type > ‘size_t’, but argument 7 has type ‘ssize_t’ > > ./trace/generated-tracers.h:10368: warning: format ‘%zd’ expects type > ‘signed size_t’, but argument 9 has type ‘ssize_t’ > ./trace/generated-tracers.h: In function ‘trace_v9fs_readdir_return’: > ./trace/generated-tracers.h:10392: warning: format ‘%zd’ expects type > ‘signed size_t’, but argument 9 has type ‘ssize_t’ > ./trace/generated-tracers.h: In function ‘trace_v9fs_write_return’: > ./trace/generated-tracers.h:10416: warning: format ‘%zd’ expects type > ‘signed size_t’, but argument 9 has type ‘ssize_t’ > CC util/qemu-config.o > ./trace/generated-tracers.h: In function ‘trace_spice_vmc_write’: > ./trace/generated-tracers.h:6516: warning: format ‘%zd’ expects type > ‘signed size_t’, but argument 6 has type ‘ssize_t’ > CC util/qemu-sockets.o > ./trace/generated-tracers.h: In function ‘trace_v9fs_read_return’: > ./trace/generated-tracers.h:10368: warning: format ‘%zd’ expects type > ‘signed size_t’, but argument 9 has type ‘ssize_t’ > ./trace/generated-tracers.h: In function ‘trace_v9fs_readdir_return’: > ./trace/generated-tracers.h:10392: warning: format ‘%zd’ expects type > ‘signed size_t’, but argument 9 has type ‘ssize_t’ > ./trace/generated-tracers.h: In function ‘trace_v9fs_write_return’: > ./trace/generated-tracers.h:10416: warning: format ‘%zd’ expects type > ‘signed size_t’, but argument 9 has type ‘ssize_t’ > CC util/notify.o > > I think this is a quirk of this elderly mingw setup that's come up > before, but I forget what the resolution of it was. > (I now have a more up to date mingw build in the mix too, so I'm > not completely averse to the suggestion of "drop this thing".)
Looks like this was always broken, it just required some extra configure argument. I would "drop this thing" or, better, you could compile with "--enable-trace-backend=nop" on the old mingw setup and without it on the new one. This has the additional advantage of better coverage. We should also add -Werror=format to the Makefile. Paolo
