On Mon, Jun 07, 2010 at 06:04:24PM +0200, Paolo Bonzini wrote: > On 06/07/2010 04:42 PM, Daniel P. Berrange wrote: > >The QMP monitor provides a number of commands for querying info about > >the QEMU binary capabilities. Given that these commands don't take > >any options and just return static data, requiring the use of QMP is > >unnecessarily onerous. This adds a new '-capabilities' command line > >argument as a syntactic sugar for accessing the QMP commands that > >just return static QEMU binary capabilities. > > > >Setting the '-capabilities' argument causes QEMU to output the requested > >data on stdout, pretty printed in JSON format. The argument expects an > >associated value to identify the data to be printed. This can be one of > >the strings version|machines|devices|cputypes|target|commands|argv|netdev > > > >To query all possible data at once, the shorthand 'all' is allowed. > > > >The output is a QDict where the key is the type of data requested, and > >the value is the JSON data from the associated monitor command. For > >example: > > A lot of this patch and the other monitor.c changes you had can likely > be moved in a capabilities.c file?
Yeah, I didn't much like adding more to vl.c or monitor.c. I can move this to a new file, or a different existing one if there are any other better suggestions Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
