> From: Tian, Kevin
> Sent: Tuesday, January 26, 2016 5:45 AM
> >
> > >           - interacts with kvmgt.c
> > >
> > >
> > >   vgpu instance management
> > >
> > >           { in i915 }
> > >
> > >           - path, create/destroy
> > >
> >
> > Yes, and since you're creating and destroying the vgpu here, this is
> > where I'd expect a struct device to be created and added to an IOMMU
> > group.  The lifecycle management should really include links between
> > the vGPU and physical GPU, which would be much, much easier to do with
> > struct devices create here rather than at the point where we start
> > doing vfio "stuff".
> 
> It's invoked here, but expecting the function exposed by vfio_vgpu.c. It's
> not good to touch vfio internal structures from another module (such as
> i915.ko)
> 

Sorry misunderstood your point. You're correct that struct device for each
vgpu should be managed here.

Thanks
Kevin

Reply via email to