On 12 January 2016 at 16:35, Alex Bennée <alex.ben...@linaro.org> wrote: > > Peter Maydell <peter.mayd...@linaro.org> writes: > >> The VIXL code includes some equality comparisons between signed >> and unsigned types. Modern gcc and clang do not complain about >> these, but older versions of gcc such as gcc 4.6.3 do. Since >> libvixl is an upstream library, the simplest approach is to >> suppress the warnings by applying -Wno-sign-compare to the >> relevant files. >> >> (GCC 4.6 is not quite yet irrelevant for us; it is the gcc >> shipped with Ubuntu Precise, for example, which is an LTS >> release not yet out of its support period.) >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> I had mistakenly thought these warnings only happened with >> the totally ancient mingw gcc, but it turns out they're a >> bit more widespread. In particular this is causing our >> Travis builds to fail: >> https://travis-ci.org/qemu/qemu/jobs/101813358 >> >> If somebody could review this then I'll apply it to master >> as a buildfix. > > Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
Thanks; applied to master. -- PMM
