On Mon, Jan 11, 2016 at 04:12:12PM +0100, Markus Armbruster wrote: > "Daniel P. Berrange" <berra...@redhat.com> writes: > > > The RBD, Curl and iSCSI block device drivers all need the ability > > to accept a password to authenticate with the remote network storage > > server. Currently RBD and iSCSI both just take the password in clear > > text as part of the block parameters which is insecure (passwords are > > visible in the process listing), while Curl doesn't support auth at > > all. > > > > This series updates all three drivers so that they use the recently > > merged QCryptoSecret API for getting passwords. Each driver gains > > a 'passwordid' property that can be set to provide the ID of a > > QCryptoSecret object instance, which in turn provides the actual > > password data. > > I'd find password-id easier to read than passwordid.
Sure, works for me - I'm ambivalent either way, so will update it. > > These patches were previously sent as part of a larger series: > > > > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html > > > > The QCryptoSecret object support was already merged, and the additions > > to qemu-img/qemu-io/qemu-nbd I'll submit separately since there is no > > strict dependancy between those additions and these patches. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|