Luiz Capitulino <lcapitul...@redhat.com> writes: > On Wed, 02 Jun 2010 20:26:58 +0200 > Markus Armbruster <arm...@redhat.com> wrote: > >> Luiz Capitulino <lcapitul...@redhat.com> writes: >> >> > From: Michael Tokarev <m...@tls.msk.ru> >> > >> > In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >> > (with fprintf) something like this: >> > >> > warning: could not open /dev/net/tun: no virtual network emulation >> > >> > this has 2 issues: >> > 1) it is not a warning really, it's a fatal error (kvm exits after >> > that), >> > 2) there's no indication as of what's actually wrong: printing errno there >> > is helpful. >> > >> > The patch below removes the "warning" prefix, uses %m (since it's linux, >> > %m is available as format modifier), and changes fprintf() to >> > %qemu_error(). >> >> To error_report(), you mean. > > It's the original commit log.. Should this be fixed? If so, Michael, > could you resend?
Or maybe it could be fixed up on commit. [...]
