On Wed, Jan 06, 2016 at 03:04:40PM +0100, Igor Mammedov wrote: > On Wed, 30 Dec 2015 23:11:50 +0300 > Roman Kagan <rka...@virtuozzo.com> wrote: > > > Windows on UEFI systems is only capable of detecting the presence and > > the type of floppy drives via corresponding ACPI objects. > > > > Those objects are added in patch 5; the preceding ones pave the way to > > it, by making the necessary data public and by moving the whole > > floppy drive controller description into runtime-generated SSDT. > > > > Note that the series conflicts with Igor's patchset for dynamic DSDT, in > > particular, with "[PATCH v2 27/51] pc: acpi: move FDC0 device from DSDT > > to SSDT"; I haven't managed to avoid that while trying to meet > > maintainer's comments. > > Tested with XPsp3 WS2008R2 WS2012R2, no regressions so far it boots fine and > can read floppy. > > So for whole series: > Reviewed-by: Igor Mammedov <imamm...@redhat.com> >
Igor, could you pls rebase this on top of your patches? I've merged them in my tree. > > Roman Kagan (6): > > i386/pc: expose identifying the floppy controller > > i386/acpi: make floppy controller object dynamic > > tests/acpi: update test data > > expose floppy drive geometry and CMOS type > > i386: populate floppy drive information in SSDT > > tests/acpi: update test data > > > > Signed-off-by: Roman Kagan <rka...@virtuozzo.com> > > Cc: "Michael S. Tsirkin" <m...@redhat.com> > > Cc: Eduardo Habkost <ehabk...@redhat.com> > > Cc: Igor Mammedov <imamm...@redhat.com> > > Cc: John Snow <js...@redhat.com> > > Cc: Kevin Wolf <kw...@redhat.com> > > Cc: Paolo Bonzini <pbonz...@redhat.com> > > Cc: Richard Henderson <r...@twiddle.net> > > Cc: qemu-bl...@nongnu.org > > Cc: qemu-sta...@nongnu.org > > --- > > changes since v4: > > - re-split out code changes from test data updates > > > > changes since v3: > > - make FDC object fully dynamic in a separate patch > > - split out support patches > > - include test data updates with the respective patches to maintain > > bisectability > > > > changes since v2: > > - explicit endianness for buffer data > > - reorder code to reduce conflicts with dynamic DSDT patchset > > - update test data > > > > hw/block/fdc.c | 11 +++++ > > hw/i386/acpi-build.c | 92 > > ++++++++++++++++++++++++++++++++++++ > > hw/i386/acpi-dsdt-isa.dsl | 18 ------- > > hw/i386/acpi-dsdt.dsl | 1 - > > hw/i386/pc.c | 46 ++++++++++-------- > > hw/i386/q35-acpi-dsdt.dsl | 7 +-- > > include/hw/block/fdc.h | 2 + > > include/hw/i386/pc.h | 3 ++ > > tests/acpi-test-data/pc/DSDT | Bin 3028 -> 2946 bytes > > tests/acpi-test-data/pc/SSDT | Bin 2486 -> 2635 bytes > > tests/acpi-test-data/pc/SSDT.bridge | Bin 4345 -> 4494 bytes > > tests/acpi-test-data/q35/DSDT | Bin 7666 -> 7578 bytes > > 12 files changed, 137 insertions(+), 43 deletions(-) > >
