On 01/05/2016 06:22 AM, Andrew Jones wrote:
> (Found by grepping for broken PRI users.)
>
> Signed-off-by: Andrew Jones <drjo...@redhat.com>
> ---
> hw/dma/xilinx_axidma.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
> index b1cfa11356a26..2ab0772cd19ae 100644
> --- a/hw/dma/xilinx_axidma.c
> +++ b/hw/dma/xilinx_axidma.c
> @@ -180,10 +180,10 @@ static inline int streamid_from_addr(hwaddr addr)
> #ifdef DEBUG_ENET
> static void stream_desc_show(struct SDesc *d)
> {
> - qemu_log("buffer_addr = " PRIx64 "\n", d->buffer_address);
> - qemu_log("nxtdesc = " PRIx64 "\n", d->nxtdesc);
> - qemu_log("control = %x\n", d->control);
> - qemu_log("status = %x\n", d->status);
> + qemu_log("buffer_addr = 0x%" PRIx64 "\n", d->buffer_address);
> + qemu_log("nxtdesc = 0x%" PRIx64 "\n", d->nxtdesc);
> + qemu_log("control = 0x%x\n", d->control);
> + qemu_log("status = 0x%x\n", d->status);This is dead code. Nothing uses stream_desc_show() even when DEBUG_ENET is defined. I'd just delete the function and #ifdef altogether, instead. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
