Hi On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake <ebl...@redhat.com> wrote: > Now that we elide unnecessary visits of empty types, we can > start using the special ':empty' type in more places. By using > the empty type as the base class of every explicit struct or > union, and as the default data for any command or event, we can > simplify later logic in qapi-{visit,commands,event} by merely > checking whether the type is empty, without also having to worry > whether a type was even supplied. > > Note that gen_object() in qapi-types still has to check for a > base, because it is also called for alternates (which have no > base). > > No change to generated code. > > Signed-off-by: Eric Blake <ebl...@redhat.com> >
Looks all good to me, but will let Markus check if that makes sense. -- Marc-André Lureau