Kevin O'Connor wrote:
On Tue, Jun 01, 2010 at 10:26:12PM +0200, Sebastian Herbszt wrote:
Jes Sorensen wrote:
>Handle 0x0401, DMI type 4, 32 bytes
>Processor Information
>- Socket Designation: CPU 1
>+ Socket Designation: CPU01
smbios.c got
snprintf((char*)start, 6, "CPU%2x", cpu_number);
It should print "CPU 1" instead of "CPU01" because the
padding should be done with spaces not zeros. Maybe
bvprintf() doesn't handle it correctly?
Space padding hasn't been implemented - nothing needed it.
With correct space padding this would be a non issue, because
the socket designation string would not have changed.
Sebastian
The bvprintf code is called from 16bit code which is very stack
sensitive - if space padding is implemented it will have to be tested
carefully.
-Kevin
