On Mon, Dec 21, 2015 at 09:18:42AM -0700, Eric Blake wrote: > On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > > Adds new methods to allow querying the length of the cipher > > key, block size and initialization vectors. > > In the subject line, I read 'lens' as a synonym for 'viewports', not > 'lengths'. But I don't know if avoiding the abbreviation is worth it, > because the subject line is already bordering on long. Maybe avoiding > it altogether is easier? > > crypto: Add additional query accessors
Yes, I'll simplify this to "crypto: add additional query accessors for cipher instances" > > > > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > crypto/cipher.c | 48 > > ++++++++++++++++++++++++++++++++++++++++++++++ > > include/crypto/cipher.h | 37 +++++++++++++++++++++++++++++++++++ > > tests/test-crypto-cipher.c | 10 ++++++++++ > > 3 files changed, 95 insertions(+) > > > > But no problems with the actual patch, so: > Reviewed-by: Eric Blake <ebl...@redhat.com> Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
