On Mon, 12/21 17:31, Eric Blake wrote: > Back in commit 764c1ca (Nov 2009), we added qstring_append_int(). > However, it did not see any use until commit 190c882 (Jan 2015). > Furthermore, it has a rather limited use case - to print anything > else, callers still have to format into a temporary buffer, unless > we want to introduce an explosion of new qstring_append_* methods > for each useful type to print. > > A much better approach is to add a wrapper that merges printf > behavior onto qstring_append, via the new qstring_append_format() > (and its vararg counterpart). In fact, with that in place, we > no longer need qstring_append_int(). > > Other immediate uses for the new function include simplifying > two existing clients of qstring_append() on a just-formatted > buffer, and the fact that we can take advantage of printf width > manipulations for more efficient indentation. > > Signed-off-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Fam Zheng <f...@redhat.com>
