Am 22.12.2015 um 17:57 hat Daniel P. Berrange geschrieben:
> On Tue, Dec 22, 2015 at 05:46:22PM +0100, Kevin Wolf wrote:
> > This patch extends qemu-img for working with locked images. It prints a
> > helpful error message when trying to access a locked image read-write,
> > and adds a 'qemu-img force-unlock' command as well as a 'qemu-img check
> > -r all --force' option in order to override a lock left behind after a
> > qemu crash.
> >
> > Signed-off-by: Kevin Wolf <kw...@redhat.com>
>
>
> > diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
> > index 9567774..dd4aebc 100644
> > --- a/qemu-img-cmds.hx
> > +++ b/qemu-img-cmds.hx
> > @@ -10,9 +10,9 @@ STEXI
> > ETEXI
> >
> > DEF("check", img_check,
> > - "check [-q] [-f fmt] [--output=ofmt] [-r [leaks | all]] [-T src_cache]
> > filename")
> > + "check [-q] [-f fmt] [--force] [--output=ofmt] [-r [leaks | all]] [-T
> > src_cache] filename")
> > STEXI
> > -@item check [-q] [-f @var{fmt}] [--output=@var{ofmt}] [-r [leaks | all]]
> > [-T @var{src_cache}] @var{filename}
> > +@item check [-q] [-f @var{fmt}] [--force] [--output=@var{ofmt}] [-r [leaks
> > | all]] [-T @var{src_cache}] @var{filename}
> > ETEXI
>
> FWIW, my patch to add a new --source arg to qemu-img commands
> means you wouldn't need to keep inventing new command line arguments
> for each new block driver option you want to support usage of in
> qemu-img - they'll all be accessible:
>
> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04021.html
Good point. I think I'd keep 'check --force' anyway because it's kind of
intuitive. Your series will be a good solution for all other qemu-img
commands, though, so I'll refrain from adding specific options there.
Kevin
