On 19 December 2015 at 21:39, Peter Crosthwaite
<crosthwaitepe...@gmail.com> wrote:
> On Fri, Dec 11, 2015 at 04:37:06PM +0000, Peter Maydell wrote:
>> + carddev = qdev_create(qdev_get_child_bus(dev, "sd-bus"), TYPE_SD);
>> + qdev_prop_set_drive(carddev, "drive", blk, errp);
>> + if (*errp) {
>
> It is generally valid for an errp to be NULL. I think we should use a
> local even if we know the caller will not pass NULL.Agreed. thanks -- PMM
