On 12/17/2015 01:51 PM, Eric Blake wrote:
> On 12/17/2015 09:49 AM, Markus Armbruster wrote:
>> Just three instances left.
>>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>
>> +++ b/qemu-nbd.c
>> @@ -257,7 +257,7 @@ static void *nbd_client_thread(void *arg)
>> fd = open(device, O_RDWR);
>> if (fd < 0) {
>> /* Linux-only, we can use %m in printf. */
>> - fprintf(stderr, "Failed to open %s: %m\n", device);
>> + error_report("Failed to open %s: %m", device);
>
> I asked back in 1/20 if we want to add error_report_errno() - if so, itI meant 1/23. > would let us switch from the comment about non-portable use of %m over > to using that new function. Of course, doesn't affect _this_ patch. > > Lots of test fallout from those three conversions, but they look fine. > > Reviewed-by: Eric Blake <ebl...@redhat.com> > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
