On 17/12/2015 13:02, Daniel P. Berrange wrote: >>> > > >>> > > $QEMU -chardev socket,host=localhost,port=9000,\ >>> > > server=on,nowait,id-charserial0,\ >>> > > logfile=/var/log/libvirt/qemu/test-serial0.log >>> > > -device isa-serial,chardev=charserial0,id=serial0 >> > >> > Why for socket only? It would be very useful for stdio and especially vc. > This is just an "RFC" so didn't want to spend the time to wire > up all of them until I got positive feedback on the idea :-)
Yes, I think it's fine. I guess one could do weird things with it such as connecting it to a named pipe, but we shouldn't waste time preventing it. > If its acceptable, then I think it could make sense to just > support optional "logfile" on every single backend, except "file" Yeah, I'd even wire it in qemu_chr_fe_write, and only prevent it for "file" at option parsing time. Or just allow it for all of them. Paolo
