On 12/16/2015 03:16 PM, John Snow wrote: > This patch adds a new explicit Floppy Drive Type option. The existing > behavior in QEMU is to automatically guess a drive type based on the > media inserted, or if a diskette is not present, arbitrarily assign one. > > This behavior can be described as "auto." This patch adds explicit > behaviors: 120, 144, 288, auto, and none. The new "auto" behavior > is intended to mimick current behavior, while the other types pick > one explicitly. > > In a future patch, the goal is to change the FDC's default drive type > from auto (falling back to 1.44MB) to auto (falling back to 2.88MB). > > In order to allow users to obtain the old behaviors, though, a mechanism > for specifying the exact type of drive we want is needed. > > This patch adds the properties, but it is not acted on yet in favor of > making those changes a little more explicitly clear in standalone patches > later in this patch set. > > Signed-off-by: John Snow <js...@redhat.com> > ---
> @@ -566,6 +569,7 @@ struct FDCtrl {
> /* Timers state */
> uint8_t timer0;
> uint8_t timer1;
> +
> };
>
Spurious blank line?
Otherwise, looks good;
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
