* Eric Blake (ebl...@redhat.com) wrote:
> On 12/15/2015 12:02 PM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
> >
> > Emit an event each time we sync the dirty bitmap on the source;
> > this helps libvirt use postcopy by giving it a kick when it
> > might be a good idea to start the postcopy.
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> > ---
> > migration/ram.c | 4 ++++
> > qapi/event.json | 11 +++++++++++
> > 2 files changed, 15 insertions(+)
>
> > +++ b/qapi/event.json
> > @@ -255,6 +255,17 @@
> > 'data': {'status': 'MigrationStatus'}}
> >
> > ##
> > +# @MIGRATION_PASS
> > +#
> > +# Emitted from the source side of a migration at the start of each pass
> > +# (when it syncs the dirty bitmap)
> > +#
> > +# Since: 2.6
>
> Missing documentation of the 'pass' member - is it a counter that says
> which pass this event is, incrementing each time through?
Thanks; yes, I added the pass parameter afterwards; I'll add:
# @pass: An incrementing count (starting at 1 on the first pass)
> Also missing docs in events.txt (although that file may go away soon,
> once we get Marc-Andre's patches in for automating documentation from
> .json files).
OK, I'll add the following (docs/qmp-events.txt):
MIGRATION_PASS
--------------
Emitted from the source side of a migration at the start of each pass
(when it syncs the dirty bitmap)
Data:
- "pass": An incrementing count (starting at 1 on the first pass)
Example:
{"timestamp": {"seconds": 1449669631, "microseconds": 239225},
"event": "MIGRATION_PASS", "data": {"pass": 2}}
Dave
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
