Peter, Thanks for the feedback on this patch. I agree with all of it, but I do have one minor quibble...
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Saturday, 5 December 2015 21:20 > On Thu, Dec 3, 2015 at 10:01 PM, Andrew Baumann > <andrew.baum...@microsoft.com> wrote: > > --- a/hw/intc/Makefile.objs > > +++ b/hw/intc/Makefile.objs > > @@ -24,6 +24,7 @@ obj-$(CONFIG_GRLIB) += grlib_irqmp.o > > obj-$(CONFIG_IOAPIC) += ioapic.o > > obj-$(CONFIG_OMAP) += omap_intc.o > > obj-$(CONFIG_OPENPIC_KVM) += openpic_kvm.o > > +obj-$(CONFIG_RASPI) += bcm2835_ic.o > > We are trying to encourage -'s for the separators in new file names, > although admittedly is does seem that intc/ is lagging here. Sigh. I can rename all the new files if you insist, but what's the rationale for this? Just for the record: % find qemu -iname *.[ch] | grep -c - 1728 % find qemu -iname *.[ch] | grep -c _ 1166 Andrew
