On Mon, Dec 07, 2015 at 08:55:03PM -0700, Eric Blake wrote: > visit_start_struct() and visit_type_enum() had a 'kind' argument > that was usually set to either the stringized version of the > corresponding qapi type name, or to NULL (although some clients > didn't even get that right). But nothing ever used the argument. > It's even hard to argue that it would be useful in a debugger, > as a stack backtrace also tells which type is being visited. > > Therefore, drop the 'kind' argument as dead. While at it, change > the signature of visit_start_struct() to place the 'name' > argument at the end (other than 'errp'), and the 'size' argument > next to 'obj'; this placement of 'name' matches matches how all > other functions in visit.h do it (visit_type_enum() places > 'strings' between 'obj' and 'name'; visit_get_next_type() places > 'promote_int' between 'type' and 'name'). This also avoids the > confusion caused by splitting related pieces of information, > where the old signature an unrelated parameter in between the > "typename" and sizeof(typename) arguments. > > Signed-off-by: Eric Blake <ebl...@redhat.com>
For spapr parts:
Acked-by: David Gibson <da...@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
