On Fri, 27 Nov 2015 17:18:06 +0000 Peter Maydell <peter.mayd...@linaro.org> wrote:
> On 29 October 2015 at 14:27, Shannon Zhao <shannon.z...@linaro.org> wrote: > > ACPI SPEC 5.0 defines GPIO-signaled ACPI Events for Hardware-reduced > > platforms(like ARM). It uses GPIO pin to trigger an event to the guest. > > For QEMU, here we add PL061 GPIO controller and use PIN 3 for > > system_powerdown, reserving PIN 0, 1, 2 for PCI hotplug, CPU hotplug and > > memory hotplug. > > > > This patchset adds system_powerdown support on ARM through both ACPI and > > DT ways. It adds a GPIO controller(here is PL061) in machine virt and > > uses GPIO-singled event for ACPI while gpio-keys for DT. It can be > > fetched from [1] and has been tested for the guests starting by ACPI or > > DT while guests use systemd or acpid. > > > Changes since v1: > > * rewrite GPIO Connection Descriptor (Michael) > > > > Shannon Zhao (8): > > hw/arm/virt: Add a GPIO controller > > hw/arm/virt-acpi-build: Add GPIO controller in ACPI DSDT table > > hw/arm/virt-acpi-build: Add power button device in ACPI DSDT table > > hw/acpi/aml-build: Add GPIO Connection Descriptor > > hw/acpi/aml-build: Add a wrapper for GPIO Interrupt Connection > > hw/arm/virt-acpi-build: Add _E03 for Power Button > > hw/arm/virt: Add QEMU powerdown notifier and hook it to GPIO Pin 3 > > hw/arm/virt: Add gpio-keys node for Poweroff using DT > > Thanks; this patchset looks generally good to me (I had a few > minor remarks about patch 8). I would appreciate review from > folks familiar with the ACPI spec for patches 2, 3, 4, 5 and 6, though. I'll do it. > > -- PMM >