On 12/01/2015 10:34 AM, Eduardo Habkost wrote:
BTW, if we are going to implement xsave in TCG, the
X86CPU<->xsave translation logic in kvm_{get,put}_xsave() could
be moved to generic code and reused by TCG instead of being
reimplemented.
That's not trivial.
In particular, stq_p isn't what the tcg helper needs to use, but rather
cpu_stq_data_ra. Given the differing parameters, we'd have to resort to some
sort of macro-ization. It's probably easiest to simply keep the two
implementations separate.
r~