On Tue 10 Nov 2015 04:44:17 AM CET, Max Reitz wrote: > bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS > before invoking bdrv_open() on that BDS. This is probably a relict from > when it used to do some modifications on that empty BDS, but now that is > unnecessary, so we can just set bs_snapshot to NULL and let bdrv_open() > do the rest. > > The same applies to bdrv_open_backing_file(). There is even a bit more > cruft here: The assert() was intended for the BDS which is indirectly > passed as the first bdrv_open() argument, so we can now drop it, too. > > Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Alberto Garcia <be...@igalia.com> Berto
