On 24/11/2015 14:36, Laszlo Ersek wrote: > On 11/24/15 13:05, Paolo Bonzini wrote: >> >> >> On 24/11/2015 04:10, Fam Zheng wrote: >>> What about all the hot-plug commands that changes the memory layout? >> >> If the guest is stopped, they shouldn't. device_add does not enable new >> BARs for example, the guest does that after it receives the ACPI event >> for PCI hotplug (or similarly an interrupt for SHPC or PCIe hotplug). >> >> Actually I like the idea of background dump, and a separate thread is an >> obvious way to do it since QEMU's memory API is mostly thread safe. > > I'm not trying to reject this patch just because "I don't like it". I > perceive it as extremely risky, and I don't know enough to review it > with *full coverage*. If you're willing to review it, and Peter can > assume the responsibility of supporting it down the road, feel free to > go ahead.
Understood. That's always the case on both the submitter and the maintainer sides. (That said, I'm not dump-guest-memory maintainer; but I _can_ make some promises on memory changes). Paolo
