On 12 November 2015 at 15:04, Eduardo Habkost <ehabk...@redhat.com> wrote: > On Thu, Nov 12, 2015 at 01:39:24PM +0200, Michael S. Tsirkin wrote: >> On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote: >> > nseries doesn't use qemu_set_hw_version() and doesn't need the >> > compatibility magic of qemu_hw_version(). Use QEMU_VERSION >> > directly. >> > >> > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> >> >> This looks very wrong. >> We should be reducing the users of QEMU_VERSION, >> not adding more. > > I would like to hear from the users and maintainers of the > nseries machines, to judge this. I assume they don't need ABI > compatibility betweeen QEMU versions, and maybe they want to know > the QEMU version they are running.
I suspect you won't find many users or maintainers on this list (or anywhere else). My guess is that this was useful for when Nokia were actively shipping an SDK that used QEMU (because then they could surface the QEMU and other component version information to SDK end-users and get better bug reports and so on as a result), but that anybody still using upstream QEMU to emulate an n-series device is capable of reporting what QEMU version they're using without having to have it reported via a dialog box inside the guest :-) thanks -- PMM
