On 11/17/2015 01:33 PM, Markus Armbruster wrote:
"Denis V. Lunev" <d...@openvz.org> writes:
EFI based VM with pflash storage for NVRAM could not be snapshoted as
libvirt configures storage as 'raw' and writable. OK, this is a libvirt
problem.
Another problem is that libvirt can not detect this failure at all
as it uses HMP for this operation. This create snapshot/delete snapshot
sequence passes silently.
The patchset adds QMP wrappers for the purpose.
At the moment I have placed 2.6 version into QAPI. Though (if you feel
appropriate) I can change it to 2.5 :) This is up to you to decide.
Nice try, but I the soft freeze boat has sailed.
OK. no problem
Please note, this patchset is made on top of
[PATCH for 2.5 v8 0/10] dataplane snapshot fixes
That one applies fine, but this one on top doesn't. Rebase?
yep. The difference is really small there (just additional 'true' parameter
in bdrv_find_all_snapshot). I think that I'll wait a day or two before
rework to give Juan and Amit their chances to blame me :)
Den